Skip to content

Dataflow: Add empty provenance column to PathGraph. #15549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 9, 2024

Conversation

aschackmull
Copy link
Contributor

This adds a column for provenance information to the PathGraph as preparation for alert provenance. In this PR the column is just added without any actual provenance information - that will be filled in a subsequent PR.

@aschackmull aschackmull force-pushed the dataflow/empty-provenance branch 2 times, most recently from 6c4969c to 27b5367 Compare February 8, 2024 10:27
@github-actions github-actions bot added the Python label Feb 8, 2024
@aschackmull aschackmull force-pushed the dataflow/empty-provenance branch from 2a5ca8b to 26cd764 Compare February 8, 2024 14:03
@aschackmull aschackmull added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Feb 8, 2024
@aschackmull aschackmull marked this pull request as ready for review February 8, 2024 14:22
@aschackmull aschackmull requested review from a team as code owners February 8, 2024 14:22
MathiasVP
MathiasVP previously approved these changes Feb 8, 2024
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++/Swift(/dataflow) LGTM!

michaelnebel
michaelnebel previously approved these changes Feb 8, 2024
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# LGTM!

atorralba
atorralba previously approved these changes Feb 9, 2024
Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java 👍 (aside from some tests failing that'll need an internal PR)

hvitved
hvitved previously approved these changes Feb 9, 2024
@aschackmull aschackmull force-pushed the dataflow/empty-provenance branch from 3bc3cd2 to 4fcb902 Compare February 9, 2024 10:34
@aschackmull
Copy link
Contributor Author

Rebased to resolve conflicts.

@aschackmull aschackmull merged commit 566351a into github:main Feb 9, 2024
@aschackmull aschackmull deleted the dataflow/empty-provenance branch February 9, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants